Skip to content

Comments

teams-for-linux: electron_32 -> electron_33#383663

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
khaneliman:teams-for-linux
Feb 21, 2025
Merged

teams-for-linux: electron_32 -> electron_33#383663
GaetanLepage merged 1 commit intoNixOS:masterfrom
khaneliman:teams-for-linux

Conversation

@khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Feb 20, 2025

Bumped in
https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.12.4

Related to #383660

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Feb 20, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 20, 2025
@nix-owners nix-owners bot requested review from chvp, muscaln and qjoly February 20, 2025 14:42
@khaneliman
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 383663


x86_64-linux

✅ 1 package built:
  • teams-for-linux

aarch64-linux

✅ 1 package built:
  • teams-for-linux

x86_64-darwin

✅ 1 package built:
  • teams-for-linux

aarch64-darwin

✅ 1 package built:
  • teams-for-linux

@TheColorman
Copy link
Contributor

Tried on x86_64-linux with no issues.

@GaetanLepage GaetanLepage merged commit daa2a44 into NixOS:master Feb 21, 2025
40 of 41 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 21, 2025

Successfully created backport PR for release-24.11:

@khaneliman khaneliman deleted the teams-for-linux branch February 21, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. ofborg-internal-error Ofborg encountered an error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants